Issue 50293007: Fix a bug in typecasts in the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 50293007: Fix a bug in typecasts in the VM. (Closed)

Created:
7 years, 1 month ago by Kevin Millikin (Google)

Modified:
7 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a bug in typecasts in the VM. When a typecast is evaluated solely for its side effects and the check is eliminated in the flow graph builder, the subexpression is not evaluated. This is wrong. Fix by evaluating the subexpression. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=29674

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -7 lines)			Patch
	M	runtime/vm/flow_graph_builder.cc	View		2 chunks	+11 lines, -5 lines	0 comments	Download
	M	tests/language/cast2_test.dart	View		2 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

7 years, 1 month ago (2013-10-31 14:39:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29674 (presubmit successful).

Expand Messages | Collapse Messages