Issue 502823004: - Introduce a synchronous GC before throwing OOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 502823004: - Introduce a synchronous GC before throwing OOM. (Closed)

Created:
6 years, 3 months ago by Ivan Posva

Modified:
6 years, 3 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Introduce a synchronous GC before throwing OOM. R=koda@google.com Committed: https://code.google.com/p/dart/source/detail?r=39618

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -10 lines)			Patch
	M	runtime/vm/heap.cc	View		2 chunks	+25 lines, -8 lines	0 comments	Download
	M	runtime/vm/pages.cc	View		2 chunks	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

iposva@google.com changed reviewers: + koda@google.com

6 years, 3 months ago (2014-08-27 19:27:25 UTC) #1

koda

lgtm https://codereview.chromium.org/502823004/diff/1/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/502823004/diff/1/runtime/vm/pages.cc#newcode36 runtime/vm/pages.cc:36: DEFINE_FLAG(bool, concurrent_sweep, true, Don't commit this until you ...

6 years, 3 months ago (2014-08-27 19:30:19 UTC) #3

Ivan Posva

6 years, 3 months ago (2014-08-27 20:37:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r39618 (presubmit successful).

Expand Messages | Collapse Messages