Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Issue 502603002: Attempt to reduce Dartium debug bot redness. (Closed)

Created:
6 years, 4 months ago by rmacnak
Modified:
6 years, 3 months ago
Reviewers:
Bill Hesse, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Attempt to reduce Dartium debug bot redness. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39504

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/co19/co19-dartium.status View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (1 generated)
rmacnak
6 years, 4 months ago (2014-08-22 20:30:27 UTC) #1
siva
lgtm
6 years, 4 months ago (2014-08-22 20:49:18 UTC) #2
rmacnak
Committed patchset #1 manually as 39504 (presubmit successful).
6 years, 4 months ago (2014-08-22 21:29:27 UTC) #3
Bill Hesse
6 years, 3 months ago (2014-09-01 14:54:42 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/502603002/diff/1/tests/co19/co19-dartium.status
File tests/co19/co19-dartium.status (right):

https://codereview.chromium.org/502603002/diff/1/tests/co19/co19-dartium.stat...
tests/co19/co19-dartium.status:640: [ $compiler == none && $runtime == dartium
&& ($mode != debug || $system != macos) ]
I really think it would be better to make a section with mode == debug and
system == macos, and put the exceptions in there as Pass or Pass,Fail.  This
file is hard to maintain, so keeping the big sections as general and uniform as
possible is necessary.

I see that about 2/3 of these tests pass, and 1/3 fail, on macos debug.  I'm not
sure we will make much progress by trying to pin down what fails on what
platform, and whether it is flaky.  I think that only by fixing most of these
failures will we turn all the bots green.  The failures are either a bug in
dartium or a problem in the test, so they need to be fixed either way.  I can't
imagine trying to maintain 6 or 8 sections, one for each platform, when adding
more co19 tests from an update.

Powered by Google App Engine
This is Rietveld 408576698