Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 50143006: Remove type argument from SecureServerSocket (Closed)

Created:
7 years, 1 month ago by Søren Gjesse
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove type argument from SecureServerSocket The VM will soon disallow this construct. R=johnniwinther@google.com, whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29448

Patch Set 1 #

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M sdk/lib/io/secure_server_socket.dart View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Søren Gjesse
7 years, 1 month ago (2013-10-29 11:54:33 UTC) #1
Bill Hesse
I think this is wrong. We should not remove extends Stream<SecureSocket>, because that is how ...
7 years, 1 month ago (2013-10-29 12:11:12 UTC) #2
Søren Gjesse
On 2013/10/29 12:11:12, Bill Hesse wrote: > I think this is wrong. We should not ...
7 years, 1 month ago (2013-10-29 12:18:34 UTC) #3
Søren Gjesse
Removed the implements ServerSocket instead. This is also how the RawServerSocket and RawSecureServerSocket are implemented. ...
7 years, 1 month ago (2013-10-29 12:30:08 UTC) #4
Johnni Winther
lgtm
7 years, 1 month ago (2013-10-29 12:36:57 UTC) #5
Bill Hesse
lgtm
7 years, 1 month ago (2013-10-29 12:59:14 UTC) #6
Søren Gjesse
7 years, 1 month ago (2013-10-29 14:18:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r29448 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698