Refactor the generation from a YAML configuration

Refactor the generation from a YAML configuration

This is in preparation of moving this into the generator.

R=kustermann@google.com
BUG=

Committed: https://github.com/dart-lang/gcloud/commit/6e0b03a

[kustermann, 2014-08-25 09:47:29]

I'd prefer if you split this up and make it a bit nicer before this goes into
the generator package.

https://codereview.chromium.org/500933002/diff/1/main.dart
File main.dart (right):

https://codereview.chromium.org/500933002/diff/1/main.dart#newcode19
main.dart:19: * Configuration of a set of pacakges generated from a set of APIs
exposed by
-> packages

https://codereview.chromium.org/500933002/diff/1/main.dart#newcode20
main.dart:20: * A Discovery Service.
A -> a

https://codereview.chromium.org/500933002/diff/1/main.dart#newcode29
main.dart:29: final missingApis = new Set();
Put generic types here and make the variables typed.

https://codereview.chromium.org/500933002/diff/1/main.dart#newcode91
main.dart:91: licenseFile = new
Uri.file(configFile).resolve(values['license']).path;
long line :)

https://codereview.chromium.org/500933002/diff/1/main.dart#newcode122
main.dart:122: });
Maybe split this up into three private static functions?

static Map<String, Package> _packagesFromYaml(yaml['packages']);
static Package _packageFromYaml();
static List<String> _calculateMissingApis(Map<String,Package> packages,
allApis);
static List<String> _calculateExcessApis(Map<String,Package> packages, allApis);

[Søren Gjesse, 2014-08-26 13:44:13]

PTAL

https://codereview.chromium.org/500933002/diff/1/main.dart
File main.dart (right):

https://codereview.chromium.org/500933002/diff/1/main.dart#newcode19
main.dart:19: * Configuration of a set of pacakges generated from a set of APIs
exposed by
On 2014/08/25 09:47:29, kustermann wrote:
> -> packages

Done.

https://codereview.chromium.org/500933002/diff/1/main.dart#newcode20
main.dart:20: * A Discovery Service.
On 2014/08/25 09:47:29, kustermann wrote:
> A -> a 

Done.

https://codereview.chromium.org/500933002/diff/1/main.dart#newcode29
main.dart:29: final missingApis = new Set();
On 2014/08/25 09:47:29, kustermann wrote:
> Put generic types here and make the variables typed.

Done.

https://codereview.chromium.org/500933002/diff/1/main.dart#newcode91
main.dart:91: licenseFile = new
Uri.file(configFile).resolve(values['license']).path;
On 2014/08/25 09:47:28, kustermann wrote:
> long line :)

Done.

https://codereview.chromium.org/500933002/diff/1/main.dart#newcode122
main.dart:122: });
On 2014/08/25 09:47:28, kustermann wrote:
> Maybe split this up into three private static functions?
> 
> static Map<String, Package> _packagesFromYaml(yaml['packages']);
> static Package _packageFromYaml();
> static List<String> _calculateMissingApis(Map<String,Package> packages,
> allApis);
> static List<String> _calculateExcessApis(Map<String,Package> packages,
allApis);

Done.

[kustermann, 2014-08-26 14:27:14]

lgtm

https://codereview.chromium.org/500933002/diff/20001/main.dart
File main.dart (right):

https://codereview.chromium.org/500933002/diff/20001/main.dart#newcode230
main.dart:230: });
Maybe a bit easier like this?

return allApis
    .where((item) => !knownApis.contains(item.id))
    .map((item) => item.id);

https://codereview.chromium.org/500933002/diff/20001/main.dart#newcode255
main.dart:255: print('WARNING: The following APIs does not exist:');
does -> do

[Søren Gjesse, 2014-08-27 07:12:42]

Committed patchset #2 manually as 6e0b03a (presubmit successful).

[Søren Gjesse, 2014-08-27 07:13:10]

https://codereview.chromium.org/500933002/diff/20001/main.dart
File main.dart (right):

https://codereview.chromium.org/500933002/diff/20001/main.dart#newcode230
main.dart:230: });
On 2014/08/26 14:27:14, kustermann wrote:
> Maybe a bit easier like this?
> 
> return allApis
>     .where((item) => !knownApis.contains(item.id))
>     .map((item) => item.id);

Done.

https://codereview.chromium.org/500933002/diff/20001/main.dart#newcode255
main.dart:255: print('WARNING: The following APIs does not exist:');
On 2014/08/26 14:27:14, kustermann wrote:
> does -> do

Done.