Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 50063003: Fix issue14236_test.dart failure (Closed)

Created:
7 years, 1 month ago by Cutch
Modified:
7 years, 1 month ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Regenerate issue14236_test.dart TBR Committed: https://code.google.com/p/dart/source/detail?r=29641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M tests/standalone/issue14236_test.dart View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
Cutch
7 years, 1 month ago (2013-10-31 05:31:05 UTC) #1
Cutch
Committed patchset #1 manually as r29641 (presubmit successful).
7 years, 1 month ago (2013-10-31 05:31:48 UTC) #2
siva
lgtm
7 years, 1 month ago (2013-10-31 16:27:39 UTC) #3
Florian Schneider
This does not scale: It should be fixed by changing the test so that it ...
7 years, 1 month ago (2013-10-31 20:32:39 UTC) #4
siva
7 years, 1 month ago (2013-10-31 20:38:55 UTC) #5
Message was sent while issue was closed.
I understand the frustration. I am in the middle of a fix that should ensure the
test will not fail when new VM symbols are added (this has been the most common
case of tripping on this). When we make structural changes to VM classes it is
going to fail and that is expected.

This test identified a bug we had in the script snapshot format that would not
have been caught if we re generate a snapshot on every build.

It will also ensure that snapshots are compatible across versions unless we
decide to change the format because we introduced a breaking change with a new
internal VM class.

Powered by Google App Engine
This is Rietveld 408576698