Issue 500253002: Run async compiler in pub Windows batch files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 500253002: Run async compiler in pub Windows batch files. (Closed)

Created:
6 years, 4 months ago by Bob Nystrom

Modified:
6 years, 4 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Run async compiler in pub Windows batch files. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=39533

Patch Set 1 #

Total comments: 2

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -80 lines)			Patch
M	sdk/bin/pub.bat	View	4 chunks	+20 lines, -13 lines	2 comments	Download
D	sdk/bin/pub_developer.bat	View	1 chunk	+0 lines, -55 lines	0 comments	Download
A +	sdk/bin/pub_sdk.bat	View	1 chunk	+2 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

rnystrom@google.com changed reviewers: + nweiz@google.com

6 years, 4 months ago (2014-08-25 21:42:02 UTC) #1

nweiz

lgtm https://codereview.chromium.org/500253002/diff/1/sdk/bin/pub.bat File sdk/bin/pub.bat (right): https://codereview.chromium.org/500253002/diff/1/sdk/bin/pub.bat#newcode40 sdk/bin/pub.bat:40: "%DART%" --package-root="%PACKAGES_DIR%" "%ASYNC_COMPILER%" "%BUILD_DIR%" --silent Long line (assuming ...

6 years, 4 months ago (2014-08-25 21:44:15 UTC) #3

Bob Nystrom

Committed patchset #1 manually as 39533 (presubmit successful).

6 years, 4 months ago (2014-08-25 21:56:24 UTC) #4

Bob Nystrom

6 years, 4 months ago (2014-08-25 21:58:48 UTC) #5

Message was sent while issue was closed.

Thanks!

https://codereview.chromium.org/500253002/diff/1/sdk/bin/pub.bat
File sdk/bin/pub.bat (right):

https://codereview.chromium.org/500253002/diff/1/sdk/bin/pub.bat#newcode40
sdk/bin/pub.bat:40: "%DART%" --package-root="%PACKAGES_DIR%" "%ASYNC_COMPILER%"
"%BUILD_DIR%" --silent
On 2014/08/25 21:44:14, nweiz wrote:
> Long line (assuming there's a way to wrap this).

Done. It uses "^" of all things.

Expand Messages | Collapse Messages