Issue 499073002: Make certain generated constructor parameters optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 499073002: Make certain generated constructor parameters optional. (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
scheglov, jwren

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make certain generated constructor parameters optional. The following constructor parameters are optional as a convenience to callers. They default to empty lists: - SourceFileEdit.edits - TypeHierarchyItem.interfaces - TypeHierarchyItem.mixins - TypeHierarchyItem.subclasses R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39510

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -24 lines)			Patch
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	4 chunks	+18 lines, -4 lines	0 comments	Download
M	pkg/analysis_server/lib/src/search/type_hierarchy.dart	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/assist_internal.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/change.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/edit/assists_test.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/change_test.dart	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/codegen_dart_protocol.dart	View	4 chunks	+26 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

6 years, 4 months ago (2014-08-23 23:56:36 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 39510 (presubmit successful).

Expand Messages | Collapse Messages