Initial 'Extract Method' refactoring implementation.

Initial 'Extract Method' refactoring implementation.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=39520

[Brian Wilkerson, 2014-08-25 07:44:00]

LGTM

https://codereview.chromium.org/498763003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/util.dart (right):

https://codereview.chromium.org/498763003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/util.dart:352: (node.parent as
VariableDeclaration).name == node;
Does this also want to ensure that there is an initializer, or is the fact that
it will be set to a default value sufficient?

[scheglov, 2014-08-25 15:36:29]

https://codereview.chromium.org/498763003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/util.dart (right):

https://codereview.chromium.org/498763003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/util.dart:352: (node.parent as
VariableDeclaration).name == node;
On 2014/08/25 07:44:00, Brian Wilkerson wrote:
> Does this also want to ensure that there is an initializer, or is the fact
that
> it will be set to a default value sufficient?

I's not very useful to extract an empty variable declaration, but it is
semantically correct and it may be a valid code to start developing some method.

[scheglov, 2014-08-25 15:38:12]

Committed patchset #1 manually as 39520 (presubmit successful).