Implement stricter rule about self referencing typedefs (fix issue 13675).

Implement stricter rule about self referencing typedefs (fix issue 13675).

R=rmacnak@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29460

[rmacnak, 2013-10-29 00:44:20]

LGTM

https://codereview.chromium.org/49853004/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/49853004/diff/1/runtime/vm/object.cc#newcode2443
runtime/vm/object.cc:2443: // parameters to refer to the owner class rather than
to the signature
I don't think there's a way to tell reflectively. We can only get to this type
parameters through the typedef, and assign (mirror) ownership there. Unlike
classes, where one can get at type variables through type arguments of other
classes or return/parameter/field types.

[regis, 2013-10-29 16:59:23]

Thanks!

https://codereview.chromium.org/49853004/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/49853004/diff/1/runtime/vm/object.cc#newcode2443
runtime/vm/object.cc:2443: // parameters to refer to the owner class rather than
to the signature
On 2013/10/29 00:44:21, Ryan Macnak wrote:
> I don't think there's a way to tell reflectively. We can only get to this type
> parameters through the typedef, and assign (mirror) ownership there. Unlike
> classes, where one can get at type variables through type arguments of other
> classes or return/parameter/field types.

In case of a typedef, the type parameters are not copied. So no problem there. I
think that instantiation of these type parameters will always occur via the
owner class as instantiator, which is correct. However, if reflection allows you
to get to the signature class of a closurized function, and then to its type
parameters, you may notice that they belong to the function owner class, rather
than to this signature class. This is my concern.

[regis, 2013-10-29 17:04:30]

Committed patchset #2 manually as r29460 (presubmit successful).