- Simplify from containment check.

- Simplify from containment check.

R=koda@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39535

[Ivan Posva, 2014-08-25 22:43:16]

iposva@google.com changed reviewers:
+ koda@google.com

[koda, 2014-08-25 22:49:26]

lgtm, with suggestion

https://codereview.chromium.org/498363003/diff/1/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://codereview.chromium.org/498363003/diff/1/runtime/vm/scavenger.cc#newc...
runtime/vm/scavenger.cc:82: from_start_(scavenger_->from_->start()),
It would be nice to somehow assert here that the "flip" of from/to has been done
(also for documentation purposes).

[Ivan Posva, 2014-08-25 22:56:23]

Thanks,
-Ivan

https://codereview.chromium.org/498363003/diff/1/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://codereview.chromium.org/498363003/diff/1/runtime/vm/scavenger.cc#newc...
runtime/vm/scavenger.cc:82: from_start_(scavenger_->from_->start()),
On 2014/08/25 22:49:26, koda wrote:
> It would be nice to somehow assert here that the "flip" of from/to has been
done
> (also for documentation purposes).

The "assertion" is the fact that from_ is NULL if the swap has not happened yet.
Thinking a bit more about this we should not even have a from_ in the Scavenger,
but instead we could pass it to the visitor explicitly.

[Ivan Posva, 2014-08-25 22:56:52]

Committed patchset #1 manually as r39535 (presubmit successful).