Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 49793005: Revert "Fixed expect, protect methods to allow any set of arguments" (Closed)

Created:
7 years, 1 month ago by kevmoo-old
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Fixed expect, protect methods to allow any set of arguments" Commit https://code.google.com/p/dart/source/detail?r=29487 Issues with Function, checked mode, and closures R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=29495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -101 lines) Patch
M pkg/unittest/lib/matcher.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/unittest/lib/src/numeric_matchers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/unittest.dart View 1 chunk +86 lines, -100 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo-old
Checked mode doesn't like Function/noSuchMethod/Closure magic
7 years, 1 month ago (2013-10-29 21:18:26 UTC) #1
Bob Nystrom
lgtm LGTM
7 years, 1 month ago (2013-10-29 21:18:53 UTC) #2
kevmoo-old
7 years, 1 month ago (2013-10-29 21:19:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r29495 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698