Issue 49793004: Inherit @published from base class (fix issue 13937)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49793004: Inherit @published from base class (fix issue 13937) (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
7 years, 1 month ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Inherit @published from base class (fix issue 13937) R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29412

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -23 lines)			Patch
M	pkg/pkg.status	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/polymer/lib/src/declaration.dart	View	3 chunks	+10 lines, -4 lines	1 comment	Download
A +	pkg/polymer/test/publish_inherited_properties_test.dart	View	3 chunks	+11 lines, -10 lines	0 comments	Download
A +	pkg/polymer/test/publish_inherited_properties_test.html	View	1 chunk	+3 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

lgtm for properties -- question on observers (the "fooChanged" guys) https://codereview.chromium.org/49793004/diff/1/pkg/polymer/lib/src/declaration.dart File pkg/polymer/lib/src/declaration.dart (right): https://codereview.chromium.org/49793004/diff/1/pkg/polymer/lib/src/declaration.dart#newcode440 ...

7 years, 1 month ago (2013-10-29 02:20:26 UTC) #2

Siggi Cherem (dart-lang)

On 2013/10/29 02:20:26, John Messerly wrote: > lgtm for properties -- question on observers (the ...

7 years, 1 month ago (2013-10-29 02:40:23 UTC) #3

Siggi Cherem (dart-lang)

7 years, 1 month ago (2013-10-29 03:40:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r29412 (presubmit successful).

Expand Messages | Collapse Messages