Issue 49793003: Remove sync ports from interop.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49793003: Remove sync ports from interop.js (Closed)

Created:
7 years, 1 month ago by justinfagnani

Modified:
7 years, 1 month ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove sync ports from interop.js BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=29579

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -529 lines)			Patch
	M	pkg/browser/lib/interop.js	View		1 chunk	+1 line, -529 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

lgtm https://codereview.chromium.org/49793003/diff/1/pkg/browser/lib/interop.js File pkg/browser/lib/interop.js (right): https://codereview.chromium.org/49793003/diff/1/pkg/browser/lib/interop.js#newcode6 pkg/browser/lib/interop.js:6: // WARNING: do not call this constructor missing ...

7 years, 1 month ago (2013-10-28 21:36:59 UTC) #2

justinfagnani

7 years, 1 month ago (2013-10-30 19:02:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29579 (presubmit successful).

Expand Messages | Collapse Messages