Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 497893002: Adds recognition of the model string for the DGBox. (Closed)

Created:
6 years, 4 months ago by zra
Modified:
6 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Adds recognition of the model string for the DGBox. Even though it is an ARMv5TE like the mindstorm, I'm creating a separate case for it since store_pc_read_offset_ may need to be different. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=39566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M runtime/vm/cpu_arm.cc View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
6 years, 4 months ago (2014-08-22 22:50:49 UTC) #1
regis
LGTM
6 years, 3 months ago (2014-08-25 17:38:00 UTC) #2
zra
6 years, 3 months ago (2014-08-26 20:38:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39566 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698