Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 497703002: Update pub barback dependency to allow 0.15.1-dev. (Closed)

Created:
6 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

Update pub barback dependency to allow 0.15.1-dev. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=39486

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/_internal/pub/lib/src/barback.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Lasse Reichstein Nielsen
6 years, 4 months ago (2014-08-22 10:59:39 UTC) #1
Søren Gjesse
lgtm
6 years, 4 months ago (2014-08-22 11:00:36 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #1 manually as 39486 (presubmit successful).
6 years, 4 months ago (2014-08-22 11:02:25 UTC) #3
Bob Nystrom
6 years, 4 months ago (2014-08-22 16:27:40 UTC) #4
nweiz
Woah, this isn't okay. Barback's version has the -dev flag because it's not ready to ...
6 years, 4 months ago (2014-08-22 18:20:06 UTC) #5
Lasse Reichstein Nielsen
On 2014/08/22 18:20:06, nweiz wrote: > Woah, this isn't okay. Barback's version has the -dev ...
6 years, 4 months ago (2014-08-22 19:31:34 UTC) #6
Søren Gjesse
6 years, 4 months ago (2014-08-25 07:03:56 UTC) #7
Message was sent while issue was closed.
On 2014/08/22 19:31:34, Lasse Reichstein Nielsen wrote:
> On 2014/08/22 18:20:06, nweiz wrote:
> > Woah, this isn't okay. Barback's version has the -dev flag because it's not
> > ready to be released.
> 
> It has the -dev flag because I added it when I changed its version dependency
on
> package:collection (https://codereview.chromium.org/463333004/).
> If there is another way to get to the same point, without tests failing, I'm
all
> for changing them back. I haven't pushed anything to pub yet.
> 
> > We don't know what additional changes we'll make before
> > that release. The current version of pub is *not* compatible with those
> changes,
> > which means that when we actually release barback 0.15.1 it will break with
> all
> > pub versions that have this constraint.
> 
> That is a problem. What would the best solution be?

As Lasse added the -dev flag the only change is the collection dependency. Can't
we just release barback 0.15.1 then?

Powered by Google App Engine
This is Rietveld 408576698