Issue 497623002: Precreate handles for the key object and smi values and use these

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 497623002: Precreate handles for the key object and smi values and use these (Closed)

Created:
6 years, 4 months ago by siva

Modified:
6 years, 4 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Precreate handles for the key object and smi values and use these handles in the find and insert methods instead of allocating a new handle each time. R=koda@google.com Committed: https://code.google.com/p/dart/source/detail?r=39479

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -23 lines)			Patch
	M	runtime/vm/hash_table.h	View	1 2	12 chunks	+35 lines, -23 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

koda

lgtm Thanks. https://chromiumcodereview.appspot.com/497623002/diff/20001/runtime/vm/hash_table.h File runtime/vm/hash_table.h (right): https://chromiumcodereview.appspot.com/497623002/diff/20001/runtime/vm/hash_table.h#newcode256 runtime/vm/hash_table.h:256: Object* KeyHandle() const { Does this need ...

6 years, 4 months ago (2014-08-21 20:57:25 UTC) #2

siva

https://chromiumcodereview.appspot.com/497623002/diff/20001/runtime/vm/hash_table.h File runtime/vm/hash_table.h (right): https://chromiumcodereview.appspot.com/497623002/diff/20001/runtime/vm/hash_table.h#newcode256 runtime/vm/hash_table.h:256: Object* KeyHandle() const { On 2014/08/21 20:57:25, koda wrote: ...

6 years, 4 months ago (2014-08-21 23:54:30 UTC) #3

siva

6 years, 4 months ago (2014-08-21 23:57:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r39479 (presubmit successful).

Expand Messages | Collapse Messages