Fix tests for pub global activate.

Fix tests for pub global activate.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39440

[Bob Nystrom, 2014-08-20 23:29:29]

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/global_packages.dart (right):

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/global_packages.dart:114: if (result.error.package
!= dep.name) throw result.error;
Document the intent here.

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/solver/version_solver.dart (right):

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/solver/version_solver.dart:282:
depender.contains(" ") ? null : _dependerVersion;
How about just returning the actual version here. Then in SolverFailure where we
check for null here, change it to ".isMagic" or something along those lines?
Using null here was hacky anyway.

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/te...
File sdk/lib/_internal/pub/test/global/activate/cached_package_test.dart
(right):

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/te...
sdk/lib/_internal/pub/test/global/activate/cached_package_test.dart:22:
Activated foo 1.0.0.""");
While you're in here, some of these tests indent the multi-line strings and some
don't. Do you mind making them consistent?

(I personally prefer indented, but I'm happy either way.)

[nweiz, 2014-08-20 23:37:59]

Code review changes

[nweiz, 2014-08-20 23:38:05]

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/global_packages.dart (right):

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/global_packages.dart:114: if (result.error.package
!= dep.name) throw result.error;
On 2014/08/20 23:29:28, Bob Nystrom wrote:
> Document the intent here.

Done.

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/solver/version_solver.dart (right):

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/solver/version_solver.dart:282:
depender.contains(" ") ? null : _dependerVersion;
On 2014/08/20 23:29:28, Bob Nystrom wrote:
> How about just returning the actual version here. Then in SolverFailure where
we
> check for null here, change it to ".isMagic" or something along those lines?
> Using null here was hacky anyway.

Done.

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/te...
File sdk/lib/_internal/pub/test/global/activate/cached_package_test.dart
(right):

https://codereview.chromium.org/496583002/diff/20001/sdk/lib/_internal/pub/te...
sdk/lib/_internal/pub/test/global/activate/cached_package_test.dart:22:
Activated foo 1.0.0.""");
On 2014/08/20 23:29:29, Bob Nystrom wrote:
> While you're in here, some of these tests indent the multi-line strings and
some
> don't. Do you mind making them consistent?
> 
> (I personally prefer indented, but I'm happy either way.)

Done.

[nweiz, 2014-08-21 00:28:50]

Committing this TBR to get the bots green.

[nweiz, 2014-08-21 00:29:23]

Committed patchset #3 manually as 39440 (presubmit successful).

[Bob Nystrom, 2014-08-21 17:33:24]

LGTM!