Issue 49613002: Fix to asiva's code review comments on TBR Cl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49613002: Fix to asiva's code review comments on TBR Cl. (Closed)

Created:
7 years, 1 month ago by Jacob

Modified:
7 years, 1 month ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -22 lines)			Patch
M	runtime/include/dart_debugger_api.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/include/dart_mirrors_api.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/debugger_api_impl.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	runtime/vm/mirrors_api_impl.cc	View	1 chunk	+0 lines, -14 lines	0 comments	Download

Total messages: 3 (0 generated)

Jacob

7 years, 1 month ago (2013-10-28 20:23:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29390 (presubmit successful).