Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 496043002: Avoid calling potentially-allocating PrintJSON methods when iterating over heap. (Closed)

Created:
6 years, 4 months ago by koda
Modified:
6 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Avoid calling potentially-allocating PrintJSON methods when iterating over heap. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=39468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M runtime/vm/object_test.cc View 2 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 4 months ago (2014-08-21 17:58:07 UTC) #1
Ivan Posva
LGTM -ip
6 years, 4 months ago (2014-08-21 18:10:57 UTC) #2
koda
6 years, 4 months ago (2014-08-21 18:19:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39468 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698