Issue 495813002: Fix memory leak in unittest - the testCases variable doesn't release the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 495813002: Fix memory leak in unittest - the testCases variable doesn't release the (Closed)

Created:
6 years, 4 months ago by dgrove

Modified:
6 years, 4 months ago

Reviewers:
Bob Nystrom, kevmoo

CC:
reviews_dartlang.org, Chris Bracken

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix memory leak in unittest - the testCases variable doesn't release the closure of each test after it runs. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=39438

Patch Set 3 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	pkg/unittest/lib/src/test_case.dart	View	1	2 chunks	+8 lines, -4 lines	0 comments	Download
	M	pkg/unittest/pubspec.yaml	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

lgtm https://codereview.chromium.org/495813002/diff/1/pkg/unittest/lib/src/test_case.dart File pkg/unittest/lib/src/test_case.dart (right): https://codereview.chromium.org/495813002/diff/1/pkg/unittest/lib/src/test_case.dart#newcode124 pkg/unittest/lib/src/test_case.dart:124: _setUp = _tearDown = _testFunction = null; Nit, ...

6 years, 4 months ago (2014-08-20 23:39:30 UTC) #2

dgrove

On 2014/08/20 23:39:30, Bob Nystrom wrote: > lgtm > > https://codereview.chromium.org/495813002/diff/1/pkg/unittest/lib/src/test_case.dart > File pkg/unittest/lib/src/test_case.dart (right): ...

6 years, 4 months ago (2014-08-20 23:41:00 UTC) #3

dgrove

6 years, 4 months ago (2014-08-20 23:42:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r39438 (presubmit successful).

Expand Messages | Collapse Messages

Issue 495813002: Fix memory leak in unittest - the testCases variable doesn't release the (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages