Issue 495623002: Don't use "final" in analysis server protocol classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 495623002: Don't use "final" in analysis server protocol classes. (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
jwren

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't use "final" in analysis server protocol classes. Doing so makes it harder to use these classes because we sometimes don't have complete information about an object at the time we need to create it. R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39420

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+232 lines, -232 lines)			Patch
	M	pkg/analysis_server/lib/src/generated_protocol.dart	View		107 chunks	+231 lines, -231 lines	0 comments	Download
	M	pkg/analysis_server/tool/spec/codegen_dart_protocol.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

6 years, 4 months ago (2014-08-20 18:53:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 39420 (presubmit successful).

Expand Messages | Collapse Messages