Use the version solver when choosing a version for pub global activate.

Use the version solver when choosing a version for pub global activate.

R=rnystrom@google.com
BUG=20287
Committed: https://code.google.com/p/dart/source/detail?r=39429

[Bob Nystrom, 2014-08-20 20:10:23]

https://codereview.chromium.org/494803003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/global_packages.dart (right):

https://codereview.chromium.org/494803003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/global_packages.dart:103: /// Installs the package
[id] and its dependencies into the system cache.
Update this.

https://codereview.chromium.org/494803003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/global_packages.dart:137: /// Finishes activating
package [dep] by saving [lockFile] in the cache.
[dep] -> [package]

https://codereview.chromium.org/494803003/diff/1/sdk/lib/_internal/pub/test/g...
File
sdk/lib/_internal/pub/test/global/activate/supports_version_solver_backtracking_test.dart
(right):

https://codereview.chromium.org/494803003/diff/1/sdk/lib/_internal/pub/test/g...
sdk/lib/_internal/pub/test/global/activate/supports_version_solver_backtracking_test.dart:22:
}),
This is a weird contrived example since you have a package here that's
effectively broken.

Instead, can you do a test that relies on an SDK constraint to cause
backtracking?

[nweiz, 2014-08-20 20:27:21]

Code review changes

[nweiz, 2014-08-20 20:27:25]

https://codereview.chromium.org/494803003/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/global_packages.dart (right):

https://codereview.chromium.org/494803003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/global_packages.dart:103: /// Installs the package
[id] and its dependencies into the system cache.
On 2014/08/20 20:10:23, Bob Nystrom wrote:
> Update this.

Done.

https://codereview.chromium.org/494803003/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/global_packages.dart:137: /// Finishes activating
package [dep] by saving [lockFile] in the cache.
On 2014/08/20 20:10:23, Bob Nystrom wrote:
> [dep] -> [package]

Done.

https://codereview.chromium.org/494803003/diff/1/sdk/lib/_internal/pub/test/g...
File
sdk/lib/_internal/pub/test/global/activate/supports_version_solver_backtracking_test.dart
(right):

https://codereview.chromium.org/494803003/diff/1/sdk/lib/_internal/pub/test/g...
sdk/lib/_internal/pub/test/global/activate/supports_version_solver_backtracking_test.dart:22:
}),
On 2014/08/20 20:10:23, Bob Nystrom wrote:
> This is a weird contrived example since you have a package here that's
> effectively broken.
> 
> Instead, can you do a test that relies on an SDK constraint to cause
> backtracking?

Done.

[Bob Nystrom, 2014-08-20 20:34:43]

One nit then LGTM!

https://codereview.chromium.org/494803003/diff/20001/sdk/lib/_internal/pub/te...
File
sdk/lib/_internal/pub/test/global/activate/supports_version_solver_backtracking_test.dart
(right):

https://codereview.chromium.org/494803003/diff/20001/sdk/lib/_internal/pub/te...
sdk/lib/_internal/pub/test/global/activate/supports_version_solver_backtracking_test.dart:24:
d.dir(cachePath, [
Document that 1.2.0 won't be picked because it doesn't allow the mock SDK
version of 0.1.2.

[nweiz, 2014-08-20 21:05:44]

Code review changes

[nweiz, 2014-08-20 21:05:51]

https://codereview.chromium.org/494803003/diff/20001/sdk/lib/_internal/pub/te...
File
sdk/lib/_internal/pub/test/global/activate/supports_version_solver_backtracking_test.dart
(right):

https://codereview.chromium.org/494803003/diff/20001/sdk/lib/_internal/pub/te...
sdk/lib/_internal/pub/test/global/activate/supports_version_solver_backtracking_test.dart:24:
d.dir(cachePath, [
On 2014/08/20 20:34:43, Bob Nystrom wrote:
> Document that 1.2.0 won't be picked because it doesn't allow the mock SDK
> version of 0.1.2.

Done.

[nweiz, 2014-08-20 21:06:10]

Committed patchset #3 manually as 39429 (presubmit successful).