Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 493843003: Round Touch attributes back to int for backwards compatibility (Closed)

Created:
6 years, 4 months ago by Leaf
Modified:
6 years, 4 months ago
Reviewers:
siva, blois
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Round Touch attributes back to int for backwards compatibility Most of the attributes in the Touch interface (clientX/Y, screenX/Y, pageX/Y, webkitRadiusX/Y) have changed to use double instead of int. Since we are generating dart:html from old idl, this immediately breaks for us as soon as these are used. This CL wraps calls to these with a round to retain the old API. BUG=http://dartbug.com/20587 R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=39426

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -16 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +31 lines, -5 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +33 lines, -7 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Touch.darttemplate View 1 chunk +40 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Leaf
6 years, 4 months ago (2014-08-20 20:05:08 UTC) #1
blois
https://codereview.chromium.org/493843003/diff/1/tools/dom/templates/html/impl/impl_Touch.darttemplate File tools/dom/templates/html/impl/impl_Touch.darttemplate (right): https://codereview.chromium.org/493843003/diff/1/tools/dom/templates/html/impl/impl_Touch.darttemplate#newcode14 tools/dom/templates/html/impl/impl_Touch.darttemplate:14: int get __clientX => JS('num', '#.clientX', this).round(); Why not ...
6 years, 4 months ago (2014-08-20 20:11:44 UTC) #2
Leaf
https://codereview.chromium.org/493843003/diff/1/tools/dom/templates/html/impl/impl_Touch.darttemplate File tools/dom/templates/html/impl/impl_Touch.darttemplate (right): https://codereview.chromium.org/493843003/diff/1/tools/dom/templates/html/impl/impl_Touch.darttemplate#newcode14 tools/dom/templates/html/impl/impl_Touch.darttemplate:14: int get __clientX => JS('num', '#.clientX', this).round(); Unfortunately we're ...
6 years, 4 months ago (2014-08-20 20:21:02 UTC) #3
blois
lgtm
6 years, 4 months ago (2014-08-20 20:23:09 UTC) #4
Leaf
6 years, 4 months ago (2014-08-20 20:29:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as 39426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698