Issue 49383003: Issue 14358. Check for assignment in any close.

Issue 49383003: Issue 14358. Check for assignment in any close. (Closed)

Created:
7 years, 1 month ago by scheglov

Modified:
7 years, 1 month ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 14358. Check for assignment in any close. https://code.google.com/p/dart/issues/detail?id=14358 R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29484

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+170 lines, -16 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java	View	2 chunks	+21 lines, -4 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/ParameterElementImpl.java	View	2 chunks	+21 lines, -4 lines	1 comment	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/VariableElementImpl.java	View	1 chunk	+11 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ResolverVisitor.java	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/VariableResolverVisitor.java	View	5 chunks	+48 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java	View	1 chunk	+48 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/49383003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java (right): https://codereview.chromium.org/49383003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java#newcode94 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LocalVariableElementImpl.java:94: public void markPotentiallyMutated() { nit: add "InScope" to ...

7 years, 1 month ago (2013-10-29 19:34:06 UTC) #2

scheglov

7 years, 1 month ago (2013-10-29 20:30:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r29484 (presubmit successful).

Expand Messages | Collapse Messages