Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 493363007: Fixes for comments in CL 474193003 (Closed)

Created:
6 years, 3 months ago by jwren
Modified:
6 years, 3 months ago
Reviewers:
Paul Berry, scheglov
CC:
reviews_dartlang.org, ricow1, Brian Wilkerson
Visibility:
Public.

Description

Fixes for comments in CL 474193003 isIsCondition() now generates to isCondition() R=paulberry@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39620

Patch Set 1 #

Total comments: 2

Messages

Total messages: 6 (0 generated)
jwren
jwren@google.com changed reviewers: + paulberry@google.com, scheglov@google.com
6 years, 3 months ago (2014-08-27 20:58:21 UTC) #1
jwren
6 years, 3 months ago (2014-08-27 20:58:21 UTC) #2
scheglov
lgtm https://codereview.chromium.org/493363007/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java (right): https://codereview.chromium.org/493363007/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java#newcode122 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java:122: public Boolean enableAsync() { Is it intentional that ...
6 years, 3 months ago (2014-08-27 21:07:56 UTC) #3
Paul Berry
lgtm
6 years, 3 months ago (2014-08-27 21:09:23 UTC) #4
jwren
https://codereview.chromium.org/493363007/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java (right): https://codereview.chromium.org/493363007/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java#newcode122 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java:122: public Boolean enableAsync() { Yes, it was my intention ...
6 years, 3 months ago (2014-08-27 21:22:17 UTC) #5
jwren
6 years, 3 months ago (2014-08-27 21:22:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 39620 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698