Issue 49253006: Compile time error on forward references to functions

Issue 49253006: Compile time error on forward references to functions (Closed)

Created:
7 years, 1 month ago by hausner

Modified:
7 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Compile time error on forward references to functions Like variables, names of functions must not be referenced before they are declared. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29835

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -15 lines)			Patch
M	runtime/bin/socket_patch.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	3 chunks	+37 lines, -13 lines	0 comments	Download
M	tests/co19/co19-co19.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2dart.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-dartium.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/ref_before_declaration_test.dart	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM. https://codereview.chromium.org/49253006/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/49253006/diff/1/runtime/vm/parser.cc#newcode5560 runtime/vm/parser.cc:5560: intptr_t name_pos = TokenPos(); const https://codereview.chromium.org/49253006/diff/1/tests/co19/co19-co19.status File tests/co19/co19-co19.status ...

7 years, 1 month ago (2013-11-04 18:18:55 UTC) #2

hausner

Also moved the forward reference check for variables so it detects if a variable initializer ...

7 years, 1 month ago (2013-11-04 18:52:23 UTC) #3

hausner

7 years, 1 month ago (2013-11-04 18:54:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r29835 (presubmit successful).

Expand Messages | Collapse Messages