Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 492243002: Introduce convenience methods into generated analysis server classes. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Introduce convenience methods into generated analysis server classes. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+386 lines, -173 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/element.dart View 2 chunks +1 line, -48 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/error.dart View 1 chunk +1 line, -31 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 7 chunks +60 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol2.dart View 7 chunks +138 lines, -30 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/change.dart View 2 chunks +0 lines, -27 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/computer/element_test.dart View 1 chunk +16 lines, -16 lines 0 comments Download
M pkg/analysis_server/test/computer/error_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/change_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 7 chunks +148 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
6 years, 4 months ago (2014-08-21 13:44:11 UTC) #1
scheglov
LGTM
6 years, 4 months ago (2014-08-21 14:17:49 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-21 15:49:48 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as 39453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698