Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 490573003: Small improvements in array code. (Closed)

Created:
6 years, 4 months ago by Florian Schneider
Modified:
6 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Small improvements in array code. Avoid emitting x - 0 in byte array view code. Always inline Lists.copy since it is freqently polymorphic. Fix printing of CreateArrayInstr. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -22 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +13 lines, -10 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
6 years, 4 months ago (2014-08-25 15:31:19 UTC) #1
Vyacheslav Egorov (Google)
lgtm
6 years, 4 months ago (2014-08-25 15:36:00 UTC) #2
Florian Schneider
6 years, 4 months ago (2014-08-25 15:45:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r39522 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698