Issue 49043003: Run all tests inside an iframe + restrict number of chrome browser processes on mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49043003: Run all tests inside an iframe + restrict number of chrome browser processes on mac (Closed)

Created:
7 years, 1 month ago by kustermann

Modified:
7 years, 1 month ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Run all tests inside an iframe + restrict number of chrome browser processes on mac R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=29367

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	tools/test.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	tools/testing/dart/browser_controller.dart	View		1 chunk	+1 line, -2 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

lgtm, I don't see why you want to run everything in iframes, that should not ...

7 years, 1 month ago (2013-10-28 16:29:56 UTC) #2

kustermann

Thanks. https://codereview.chromium.org/49043003/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (left): https://codereview.chromium.org/49043003/diff/1/tools/testing/dart/browser_controller.dart#oldcode79 tools/testing/dart/browser_controller.dart:79: const ['safari', 'ff', 'firefox', 'chrome']; On 2013/10/28 16:29:56, ...

7 years, 1 month ago (2013-10-28 16:31:08 UTC) #3

kustermann

7 years, 1 month ago (2013-10-28 16:31:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r29367 (presubmit successful).

Expand Messages | Collapse Messages