Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 49003012: Search for main in the exported names of the main library, not in the library itself. (Closed)

Created:
7 years, 1 month ago by kasperl
Modified:
7 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Search for main in the exported names of the main library, not in the library itself. R=johnniwinther@google.com BUG=http://dartbug.com/14762 Committed: https://code.google.com/p/dart/source/detail?r=29807

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add more tests. #

Patch Set 3 : Add more tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -17 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 1 2 4 chunks +12 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/language/export_ambiguous_main_a.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/language/export_ambiguous_main_b.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/language/export_ambiguous_main_negative_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
A + tests/language/export_double_same_main_test.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
A + tests/language/export_main_override_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + tests/language/export_main_test.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kasperl
7 years, 1 month ago (2013-11-04 11:41:57 UTC) #1
Johnni Winther
Can you add a unittest for duplicate export of 'main', similar to package_root_test and/or import_test? ...
7 years, 1 month ago (2013-11-04 11:57:22 UTC) #2
kasperl
PTAL.
7 years, 1 month ago (2013-11-04 13:40:27 UTC) #3
Johnni Winther
lgtm
7 years, 1 month ago (2013-11-04 13:47:46 UTC) #4
kasperl
7 years, 1 month ago (2013-11-04 13:50:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r29807 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698