Issue 490023004: On ia32 allow powers of two and corresponding full bit masks as safe smis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 490023004: On ia32 allow powers of two and corresponding full bit masks as safe smis. (Closed)

Created:
6 years, 4 months ago by Vyacheslav Egorov (Google)

Modified:
6 years, 4 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

On ia32 allow powers of two and corresponding full bit masks as safe smis. This considerably improves generated code allowing these values (commonly used in bitwise computations) to be embedded as immediates. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=39449

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -6 lines)			Patch
	M	runtime/vm/assembler_ia32.h	View		1 chunk	+18 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

6 years, 4 months ago (2014-08-21 12:46:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 39449 (presubmit successful).

Expand Messages | Collapse Messages