Issue 489993004: Private names are not exported, not even if the library imports itself

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 489993004: Private names are not exported, not even if the library imports itself (Closed)

Created:
6 years, 4 months ago by hausner

Modified:
6 years, 4 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Private names are not exported, not even if the library imports itself Prevent access to a private name if it’s imported through a self-import. Adding a test case. Fixes issue 20162 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39459

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -1 line)			Patch
	M	runtime/vm/parser.cc	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
	A	tests/language/import_self_test.dart	View		1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/489993004/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/489993004/diff/1/runtime/vm/parser.cc#newcode9556 runtime/vm/parser.cc:9556: if (ident.CharAt(0) == '_') { Should we use ...

6 years, 4 months ago (2014-08-21 17:02:21 UTC) #2

hausner

Thank you. https://codereview.chromium.org/489993004/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/489993004/diff/1/runtime/vm/parser.cc#newcode9556 runtime/vm/parser.cc:9556: if (ident.CharAt(0) == '_') { On 2014/08/21 ...

6 years, 4 months ago (2014-08-21 17:06:20 UTC) #3

hausner

6 years, 4 months ago (2014-08-21 17:07:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r39459 (presubmit successful).

Expand Messages | Collapse Messages