Initial 'Extract Local' implementation.

Initial 'Extract Local' implementation.

Missing:

1. suggested names;
2. offsets and lengths of occurrences.
3. some clean ups.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=39434

[Brian Wilkerson, 2014-08-20 22:11:16]

LGTM

https://codereview.chromium.org/489973002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/util.dart (right):

https://codereview.chromium.org/489973002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/util.dart:1113: static
List<Token> getTokens(String s) {
This seems slow, especially for large files. Do we ever need the list for
anything other than iterating? Perhaps we should (later) add an iterator that
can iterate over token streams.

https://codereview.chromium.org/489973002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
(right):

https://codereview.chromium.org/489973002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/extract_local.dart:191:
stringLiteralPart.startsWith("\"") ||
Why not use single quotes instead of quoting the double quote?

https://codereview.chromium.org/489973002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/extract_local.dart:397:
invalidSelection('Can not extract name part of a property access.');
"Can not" --> "Cannot" (here and below)

[scheglov, 2014-08-20 22:19:21]

https://codereview.chromium.org/489973002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/correction/util.dart (right):

https://codereview.chromium.org/489973002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/correction/util.dart:1113: static
List<Token> getTokens(String s) {
On 2014/08/20 22:11:16, Brian Wilkerson wrote:
> This seems slow, especially for large files. Do we ever need the list for
> anything other than iterating? Perhaps we should (later) add an iterator that
> can iterate over token streams.

Acknowledged.

https://codereview.chromium.org/489973002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/refactoring/extract_local.dart
(right):

https://codereview.chromium.org/489973002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/extract_local.dart:191:
stringLiteralPart.startsWith("\"") ||
On 2014/08/20 22:11:16, Brian Wilkerson wrote:
> Why not use single quotes instead of quoting the double quote?

Done.

https://codereview.chromium.org/489973002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/refactoring/extract_local.dart:397:
invalidSelection('Can not extract name part of a property access.');
On 2014/08/20 22:11:16, Brian Wilkerson wrote:
> "Can not" --> "Cannot" (here and below)

Done.

[scheglov, 2014-08-20 22:20:29]

Committed patchset #2 manually as 39434 (presubmit successful).