Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 489813002: include inherited members in invocation suggestions (Closed)

Created:
6 years, 4 months ago by danrubel
Modified:
6 years, 4 months ago
Reviewers:
jwren
CC:
reviews_dartlang.org
Visibility:
Public.

Description

include inherited members in invocation suggestions BUG= R=jwren@google.com Committed: https://code.google.com/p/dart/source/detail?r=39413

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -11 lines) Patch
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/invocation_computer_test.dart View 5 chunks +44 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danrubel
6 years, 4 months ago (2014-08-20 12:55:25 UTC) #1
jwren
On 2014/08/20 12:55:25, danrubel wrote: LGTM
6 years, 4 months ago (2014-08-20 14:12:55 UTC) #2
danrubel
6 years, 4 months ago (2014-08-20 16:13:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 39413 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698