Issue 488413003: Initial factory constructors for generated objects in Java server.

Issue 488413003: Initial factory constructors for generated objects in Java server. (Closed)

Created:
6 years, 4 months ago by jwren

Modified:
6 years, 4 months ago

Reviewers:
Paul Berry, scheglov, Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Initial factory constructors for generated objects in Java server. R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=39481

Patch Set 3 : rebase with bleeding_edge #

Patch Set 5 : review and rebase #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+988 lines, -96 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java	View	1 2 3 4	3 chunks	+25 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisError.java	View	1 2 3 4	3 chunks	+28 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisOptions.java	View	1 2 3 4	3 chunks	+28 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AnalysisStatus.java	View	1 2 3 4	3 chunks	+25 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ChangeContentOverlay.java	View	1 2 3 4	3 chunks	+25 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java	View	1 2 3 4	3 chunks	+40 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Element.java	View	1 2 3 4	3 chunks	+29 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Error.java	View	1 2 3 4	3 chunks	+26 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ErrorFixes.java	View	1 2 3 4	3 chunks	+25 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/ExecutableFile.java	View	1 2 3 4	3 chunks	+25 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/FoldingRegion.java	View	1 2 3 4	3 chunks	+26 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/HighlightRegion.java	View	1 2 3 4	3 chunks	+26 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/HoverInformation.java	View	1 2 3 4	3 chunks	+33 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/LinkedEditGroup.java	View	1 2 3 4	3 chunks	+26 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/LinkedEditSuggestion.java	View	1 2 3 4	3 chunks	+25 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Location.java	View	1 2 3 4	3 chunks	+28 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/NavigationRegion.java	View	1 2 3 4	3 chunks	+26 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Occurrences.java	View	1 2 3 4	3 chunks	+26 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Outline.java	View	1 2 3 4	3 chunks	+27 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/OverriddenMember.java	View	1 2 3 4	3 chunks	+25 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/OverrideMember.java	View	1 2 3 4	3 chunks	+27 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/Position.java	View	1 2 3 4	3 chunks	+25 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringMethodParameter.java	View	1 2 3 4	3 chunks	+28 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RefactoringProblem.java	View	1 2 3 4	3 chunks	+26 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/RemoveContentOverlay.java	View	1 2 3 4	3 chunks	+24 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResult.java	View	1 2 3 4	3 chunks	+27 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SourceChange.java	View	1 2 3 4	3 chunks	+27 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SourceEdit.java	View	1 2 3 4	3 chunks	+27 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SourceFileEdit.java	View	1 2 3 4	3 chunks	+25 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/TypeHierarchyItem.java	View	1 2 3 4	3 chunks	+30 lines, -3 lines	0 comments	Download
A	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/utilities/general/JsonUtilities.java	View	1	1 chunk	+72 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/codegen_java_types.dart	View	1 2 3 4	5 chunks	+106 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jwren

There will be follow-up CLs to cleanup and document, but I wanted this to get ...

6 years, 4 months ago (2014-08-21 22:12:19 UTC) #1

scheglov

LGTM https://codereview.chromium.org/488413003/diff/60001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java (right): https://codereview.chromium.org/488413003/diff/60001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java#newcode59 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java:59: public AddContentOverlay (String type, String content) { Is ...

6 years, 4 months ago (2014-08-22 01:11:35 UTC) #3

jwren

https://codereview.chromium.org/488413003/diff/60001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java (right): https://codereview.chromium.org/488413003/diff/60001/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java#newcode59 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java:59: public AddContentOverlay (String type, String content) { On 2014/08/22 ...

6 years, 4 months ago (2014-08-22 03:32:03 UTC) #4

jwren

Committed patchset #5 manually as 39481 (presubmit successful).

6 years, 4 months ago (2014-08-22 03:33:26 UTC) #5

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages