Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 48833004: Modifies assertion for possibly null code pointer. (Closed)

Created:
7 years, 1 month ago by zra
Modified:
7 years, 1 month ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Modifies assertion for possibly null code pointer. A callee function's code pointer may be nulled by a GC pass during inlining. The code itself is still around because the inlining function retains a reference, but a future change will ensure that the GC pass doesn't null code pointers in inlined functions. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=29400

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M runtime/vm/code_generator.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/pages.cc View 1 2 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zra
7 years, 1 month ago (2013-10-28 21:00:21 UTC) #1
srdjan
lgtm
7 years, 1 month ago (2013-10-28 21:04:55 UTC) #2
zra
7 years, 1 month ago (2013-10-28 21:58:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r29400 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698