Issue 488103003: Add SearchResultKind.UNKNOWN to the analysis server API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 488103003: Add SearchResultKind.UNKNOWN to the analysis server API. (Closed)

Created:
6 years, 4 months ago by Paul Berry

Modified:
6 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add SearchResultKind.UNKNOWN to the analysis server API. This resolves an inconsistency between the spec and the analysis server behavior: the server returns a SearchResultKind of UNKNOWN if the MatchKind from the analysis engine is one of the following types: - ANGULAR_REFERENCE - ANGULAR_CLOSING_TAG_REFERENCE R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=39411

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -0 lines)			Patch
M	editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/SearchResultKind.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/doc/api.html	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/src/generated_protocol.dart	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Berry

6 years, 4 months ago (2014-08-20 15:32:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as 39411 (presubmit successful).

Expand Messages | Collapse Messages