Issue 487973002: Track per-class promotion stats.

Issue 487973002: Track per-class promotion stats. (Closed)

Created:
6 years, 4 months ago by koda

Modified:
6 years, 4 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Track per-class promotion stats. This will be useful for allocation policy and heap growth policy. Also include these stats in the VM service. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=39415

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -0 lines)			Patch
M	runtime/bin/vmservice/observatory/lib/src/service/object.dart	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/class_table.h	View	1 2	3 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/class_table.cc	View	1 2	6 chunks	+24 lines, -0 lines	0 comments	Download
M	runtime/vm/heap.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/heap_test.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Cutch

lgtm with tiny comment https://codereview.chromium.org/487973002/diff/20001/runtime/vm/class_table.h File runtime/vm/class_table.h (right): https://codereview.chromium.org/487973002/diff/20001/runtime/vm/class_table.h#newcode79 runtime/vm/class_table.h:79: intptr_t promoted_size; Is this accumulated ...

6 years, 4 months ago (2014-08-20 17:46:57 UTC) #2

koda

https://codereview.chromium.org/487973002/diff/20001/runtime/vm/class_table.h File runtime/vm/class_table.h (right): https://codereview.chromium.org/487973002/diff/20001/runtime/vm/class_table.h#newcode79 runtime/vm/class_table.h:79: intptr_t promoted_size; On 2014/08/20 17:46:57, Cutch wrote: > Is ...

6 years, 4 months ago (2014-08-20 17:49:28 UTC) #3

koda

6 years, 4 months ago (2014-08-20 17:57:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r39415 (presubmit successful).

Expand Messages | Collapse Messages