Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 48763008: Return zone from initPolymer (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
7 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pkg/polymer/lib/src/loader.dart View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-29 00:38:27 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/48763008/diff/1/pkg/polymer/lib/src/loader.dart File pkg/polymer/lib/src/loader.dart (right): https://codereview.chromium.org/48763008/diff/1/pkg/polymer/lib/src/loader.dart#newcode37 pkg/polymer/lib/src/loader.dart:37: var zone = dirtyCheckZone(); return dirtyCheckZone()..run(_initPolymerOptimized); :)
7 years, 1 month ago (2013-10-29 02:16:17 UTC) #2
Siggi Cherem (dart-lang)
https://codereview.chromium.org/48763008/diff/1/pkg/polymer/lib/src/loader.dart File pkg/polymer/lib/src/loader.dart (right): https://codereview.chromium.org/48763008/diff/1/pkg/polymer/lib/src/loader.dart#newcode37 pkg/polymer/lib/src/loader.dart:37: var zone = dirtyCheckZone(); On 2013/10/29 02:16:17, John Messerly ...
7 years, 1 month ago (2013-10-29 02:53:13 UTC) #3
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-10-29 02:54:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29410 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698