Fix bugs in StreamController.addStream.

Fix bugs in StreamController.addStream.

Add optional 'cancelOnError' to addStream method. It still defaults
to true.
Resume the added stream when adding a listener (14332).
Handle cancel-on-error correctly, so the future completes as well (14334).

BUG= http://dartbug.com/14332 http://dartbug.com/14334
R=ajohnsen@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29419

[Anders Johnsen, 2013-10-28 13:44:26]

lgtm

https://codereview.chromium.org/48733002/diff/1/sdk/lib/async/stream_controll...
File sdk/lib/async/stream_controller.dart (right):

https://codereview.chromium.org/48733002/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:179: abstract class StreamControllerSink<T>
extends StreamSink<T> {
Is this worth a hole new type? dart:async is already quite bloated. Maybe we
should consider if this should be the default interface?

https://codereview.chromium.org/48733002/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:179: abstract class StreamControllerSink<T>
extends StreamSink<T> {
Thinking some more about it, I think it's a property of the StreamController,
not of the sink/addStream.

https://codereview.chromium.org/48733002/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:361: * Returns a future which completes
when the stream adding is done.
... when the source stream is done.

https://codereview.chromium.org/48733002/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:381: cancelOnError);
Nit: argument should be on one line or each on a line.

https://codereview.chromium.org/48733002/diff/50001/tests/lib/async/stream_fr...
File tests/lib/async/stream_from_iterable_test.dart (right):

https://codereview.chromium.org/48733002/diff/50001/tests/lib/async/stream_fr...
tests/lib/async/stream_from_iterable_test.dart:117:
sink.addStream(from).then((_) {
Add test with two 'addStream' on controller.

[Lasse Reichstein Nielsen, 2013-10-29 08:49:45]

https://codereview.chromium.org/48733002/diff/1/sdk/lib/async/stream_controll...
File sdk/lib/async/stream_controller.dart (right):

https://codereview.chromium.org/48733002/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:179: abstract class StreamControllerSink<T>
extends StreamSink<T> {
You are right, it's too much overhead just so that controller.sink could accept
an extra argument on addStream. Which is silly, because you can only use it if
you know you have a controller, and then you can use the controller directly.
The extra type has been removed.

https://codereview.chromium.org/48733002/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:361: * Returns a future which completes
when the stream adding is done.
On 2013/10/28 13:44:26, Anders Johnsen wrote:
> ... when the source stream is done.

Done.

https://codereview.chromium.org/48733002/diff/1/sdk/lib/async/stream_controll...
sdk/lib/async/stream_controller.dart:381: cancelOnError);
That's silly.
But done.

[Anders Johnsen, 2013-10-29 08:55:37]

LGTM!

[Lasse Reichstein Nielsen, 2013-10-29 09:00:00]

Committed patchset #4 manually as r29419 (presubmit successful).