Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 48713013: Fix http://dartbug.com/14763 (Closed)

Created:
7 years, 1 month ago by Ivan Posva
Modified:
7 years, 1 month ago
Reviewers:
vsm, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, kasperl
Visibility:
Public.

Description

Fix http://dartbug.com/14763 - Find main in the exported names of the root library. - Unify how the main function is called from spawnUri and the initial isolate. Committed: https://code.google.com/p/dart/source/detail?r=29865

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -52 lines) Patch
M runtime/bin/builtin.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/bin/main.cc View 2 chunks +52 lines, -39 lines 0 comments Download
M runtime/lib/isolate.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/debugger.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tests/co19/co19-co19.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/co19/co19-dartium.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Posva
7 years, 1 month ago (2013-11-05 00:51:48 UTC) #1
Ivan Posva
7 years, 1 month ago (2013-11-05 00:55:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r29865 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698