Issue 48713012: Fixes in custom_element.dart: some of the code was broken, fixes needed for

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48713012: Fixes in custom_element.dart: some of the code was broken, fixes needed for (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)

Modified:
7 years, 1 month ago

Reviewers:
Emily Fortuna, Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixes in custom_element.dart: some of the code was broken, fixes needed for those using web-ui (patch follows from issue 53293003) R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=29860

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -34 lines)			Patch
	M	pkg/custom_element/lib/custom_element.dart	View	1 2 3	8 chunks	+20 lines, -26 lines	0 comments	Download
	M	pkg/pkg.status	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

Siggi Cherem (dart-lang)

fixes https://code.google.com/p/dart/issues/detail?id=14804

7 years, 1 month ago (2013-11-04 23:43:28 UTC) #1

Siggi Cherem (dart-lang)

7 years, 1 month ago (2013-11-04 23:47:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 manually as r29860 (presubmit successful).