Issue 48643004: Update status file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48643004: Update status file (Closed)

Created:
7 years, 1 month ago by Søren Gjesse

Modified:
7 years, 1 month ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update status file Treat drt and dartium the same for fromEnvironment TBR=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=29645

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/corelib/corelib.status	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #1 manually as r29645 (presubmit successful).

7 years, 1 month ago (2013-10-31 06:38:44 UTC) #2

ngeoffray

7 years, 1 month ago (2013-10-31 07:39:16 UTC) #3

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/48643004/diff/1/tests/corelib/corelib.status
File tests/corelib/corelib.status (right):

https://codereview.chromium.org/48643004/diff/1/tests/corelib/corelib.status#...
tests/corelib/corelib.status:19: [ $compiler == none && ($runtime == drt ||
$runtime == dartium) ]
Add a comment why we skip those?

Expand Messages | Collapse Messages