Issue 48593002: Add a note on watching files on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48593002: Add a note on watching files on Linux. (Closed)

Created:
7 years, 1 month ago by Søren Gjesse

Modified:
7 years, 1 month ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a note on watching files on Linux. BUG=http://dartbug.com/13562 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=29355

Patch Set 2 : Addressed review comments #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	sdk/lib/io/file_system_entity.dart	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm https://codereview.chromium.org/48593002/diff/1/sdk/lib/io/file_system_entity.dart File sdk/lib/io/file_system_entity.dart (right): https://codereview.chromium.org/48593002/diff/1/sdk/lib/io/file_system_entity.dart#newcode352 sdk/lib/io/file_system_entity.dart:352: * Note: When watching files directly delete events ...

7 years, 1 month ago (2013-10-28 12:05:56 UTC) #2

Søren Gjesse

Committed patchset #2 manually as r29355 (presubmit successful).

7 years, 1 month ago (2013-10-28 12:08:48 UTC) #3

Søren Gjesse

7 years, 1 month ago (2013-10-28 12:08:55 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/48593002/diff/1/sdk/lib/io/file_system_entity...
File sdk/lib/io/file_system_entity.dart (right):

https://codereview.chromium.org/48593002/diff/1/sdk/lib/io/file_system_entity...
sdk/lib/io/file_system_entity.dart:352: *     Note: When watching files directly
delete events might not happen
On 2013/10/28 12:05:56, Anders Johnsen wrote:
> `,` after directly.

Done.

Expand Messages | Collapse Messages

Issue 48593002: Add a note on watching files on Linux. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages