Generate a toJson method onto our generated types, int is now represented as the wrapped Integer in…

Generate a toJson method onto our generated types, int is now represented as the wrapped Integer in class

R=brianwilkerson@google.com, paulberry@google.com

Committed: https://code.google.com/p/dart/source/detail?r=39428

[Paul Berry, 2014-08-19 20:51:12]

lgtm assuming issues with lists are sorted out.

https://codereview.chromium.org/485213004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java
(right):

https://codereview.chromium.org/485213004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java:369:
// the type Object cannot be represented in JsonObject
parameterNames isn't an object, it's a List<String>.  Same issue with
parameterTypes below.

https://codereview.chromium.org/485213004/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/codegen_java.dart (right):

https://codereview.chromium.org/485213004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_java.dart:181: if (type is TypeReference)
{
You could also do:

if (type is TypeReference) {
  return api.types.containsKey(type.typeName);
}
return false;

https://codereview.chromium.org/485213004/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/codegen_java_types.dart (right):

https://codereview.chromium.org/485213004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_java_types.dart:123: 
Unexpected whitespace

[Brian Wilkerson, 2014-08-19 21:57:41]

LGTM

https://codereview.chromium.org/485213004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java
(right):

https://codereview.chromium.org/485213004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java:83:
// Create a JsonObject
Personally, I don't find the generated comments to be helpful.

[jwren, 2014-08-20 20:51:21]

https://codereview.chromium.org/485213004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java
(right):

https://codereview.chromium.org/485213004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/AddContentOverlay.java:83:
// Create a JsonObject
Done.  All removed.

https://codereview.chromium.org/485213004/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java
(right):

https://codereview.chromium.org/485213004/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestion.java:369:
// the type Object cannot be represented in JsonObject
On 2014/08/19 20:51:12, Paul Berry wrote:
> parameterNames isn't an object, it's a List<String>.  Same issue with
> parameterTypes below.

Done.

https://codereview.chromium.org/485213004/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/codegen_java.dart (right):

https://codereview.chromium.org/485213004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_java.dart:181: if (type is TypeReference)
{
On 2014/08/19 20:51:12, Paul Berry wrote:
> You could also do:
> 
> if (type is TypeReference) {
>   return api.types.containsKey(type.typeName);
> }
> return false;

Acknowledged.

https://codereview.chromium.org/485213004/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/codegen_java_types.dart (right):

https://codereview.chromium.org/485213004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_java_types.dart:123: 
On 2014/08/19 20:51:12, Paul Berry wrote:
> Unexpected whitespace

Done.

https://codereview.chromium.org/485213004/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/codegen_java_types.dart:123: 
On 2014/08/19 20:51:12, Paul Berry wrote:
> Unexpected whitespace

Done.

[jwren, 2014-08-20 20:54:17]

Committed patchset #1 manually as 39428 (presubmit successful).