Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 48513003: If a move has matching target/destination, signal the event as create or delete. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

If a move has matching target/destination, signal the event as create or delete. BUG=https://code.google.com/p/dart/issues/detail?id=14424 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29354

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix list size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -7 lines) Patch
M runtime/bin/file_patch.dart View 3 chunks +9 lines, -2 lines 0 comments Download
M runtime/bin/file_system_watcher_android.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/file_system_watcher_linux.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/file_system_watcher_macos.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/file_system_watcher_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 1 month ago (2013-10-28 11:38:30 UTC) #1
Søren Gjesse
lgtm, with comments https://codereview.chromium.org/48513003/diff/1/runtime/bin/file_system_watcher_android.cc File runtime/bin/file_system_watcher_android.cc (right): https://codereview.chromium.org/48513003/diff/1/runtime/bin/file_system_watcher_android.cc#newcode70 runtime/bin/file_system_watcher_android.cc:70: Dart_Handle event = Dart_NewList(3); 3 -> ...
7 years, 1 month ago (2013-10-28 12:01:53 UTC) #2
Anders Johnsen
https://codereview.chromium.org/48513003/diff/1/runtime/bin/file_system_watcher_android.cc File runtime/bin/file_system_watcher_android.cc (right): https://codereview.chromium.org/48513003/diff/1/runtime/bin/file_system_watcher_android.cc#newcode70 runtime/bin/file_system_watcher_android.cc:70: Dart_Handle event = Dart_NewList(3); On 2013/10/28 12:01:53, Søren Gjesse ...
7 years, 1 month ago (2013-10-28 12:07:25 UTC) #3
Anders Johnsen
7 years, 1 month ago (2013-10-28 12:07:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r29354 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698