Issue 48493003: Make FileSystemWatcher work on MIPS and make watching on android the same as linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 48493003: Make FileSystemWatcher work on MIPS and make watching on android the same as linux. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen

Modified:
7 years, 1 month ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make FileSystemWatcher work on MIPS and make watching on android the same as linux. BUG=https://code.google.com/p/dart/issues/detail?id=13553 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=29548

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -4 lines)			Patch
	M	runtime/bin/file_system_watcher_android.cc	View		2 chunks	+9 lines, -3 lines	2 comments	Download
	M	runtime/bin/file_system_watcher_linux.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/48493003/diff/1/runtime/bin/file_system_watcher_android.cc File runtime/bin/file_system_watcher_android.cc (right): https://codereview.chromium.org/48493003/diff/1/runtime/bin/file_system_watcher_android.cc#newcode27 runtime/bin/file_system_watcher_android.cc:27: int fd = TEMP_FAILURE_RETRY(inotify_init()); Please add a comment ...

7 years, 1 month ago (2013-10-30 14:05:51 UTC) #2

Anders Johnsen

https://codereview.chromium.org/48493003/diff/1/runtime/bin/file_system_watcher_android.cc File runtime/bin/file_system_watcher_android.cc (right): https://codereview.chromium.org/48493003/diff/1/runtime/bin/file_system_watcher_android.cc#newcode27 runtime/bin/file_system_watcher_android.cc:27: int fd = TEMP_FAILURE_RETRY(inotify_init()); On 2013/10/30 14:05:51, Søren Gjesse ...

7 years, 1 month ago (2013-10-30 14:17:21 UTC) #3

Anders Johnsen

7 years, 1 month ago (2013-10-30 14:17:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r29548 (presubmit successful).

Expand Messages | Collapse Messages