Issue 484693002: Don't check for reaching type in the RangeAnalysis::GetRange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 484693002: Don't check for reaching type in the RangeAnalysis::GetRange. (Closed)

Created:
6 years, 4 months ago by Vyacheslav Egorov (Google)

Modified:
6 years, 4 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't check for reaching type in the RangeAnalysis::GetRange. Canonicalizer rewrites v1 = _Int32Array._new(v0) v2 = v1.length use(v2) as v1 = _Int32Array._new(v0) use(v0) without changing reaching type of v0 to Smi at the use. This means right now we can't expect that uses at Smi operations have propagated smi type. BUG= R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=39331

Patch Set 1 #

Patch Set 2 : fix UnboxIntegerInstr::InferRange #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -22 lines)			Patch
	M	runtime/vm/flow_graph_range_analysis.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	runtime/vm/flow_graph_range_analysis.cc	View	1	9 chunks	+13 lines, -21 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

6 years, 4 months ago (2014-08-18 15:04:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as 39331 (presubmit successful).

Expand Messages | Collapse Messages