Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 484313002: Make search.findElementReferences.result.element field optional. (Closed)

Created:
6 years, 4 months ago by Paul Berry
Modified:
6 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make search.findElementReferences.result.element field optional. This resolves an inconsistency between the spec and the analysis server behavior: the server doesn't populete the "element" field if no element could be found. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=39388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M pkg/analysis_server/doc/api.html View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 4 chunks +8 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Berry
Note: I'm not sure whether or not this is what we want in the long ...
6 years, 4 months ago (2014-08-19 20:33:37 UTC) #1
Brian Wilkerson
LGTM, but we should revisit the larger question later
6 years, 4 months ago (2014-08-19 21:52:07 UTC) #2
Paul Berry
6 years, 4 months ago (2014-08-19 21:56:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 39388 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698